Skip to content

Conversation

@amustaque97
Copy link
Contributor

closes #2037

@github-actions
Copy link

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github

@amustaque97 amustaque97 marked this pull request as ready for review November 26, 2025 11:57
@rustbot
Copy link

rustbot commented Nov 26, 2025

rust_team_data/src/v1.rs has been modified, it is used (as a git dependency) by multiple sub-projects like triagebot, the www.rust-lang.org website and others.

If you are changing the data structures, please make sure that the changes are not going to break serde deserialization (adding a field is fine; removing or renaming a field isn't).

If you must do a breaking change to the format, make sure to coordinate it with all the users of the rust_team_data crate.

cc @Urgau

Copy link
Member

@marcoieni marcoieni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I left a few minor comments. After addressing them I will test this :)

@amustaque97 amustaque97 force-pushed the feat-2037-privision-environments branch from 1609c0d to 8f9f0ca Compare November 27, 2025 12:27
@amustaque97
Copy link
Contributor Author

Addressed all the review comments. Thanks for the review!
Ran a basic sanity check, and it is working locally.
Screenshot 2025-11-27 at 6 06 42 PM

@marcoieni
Copy link
Member

The dry run worked 🥳

Can you add these environments to the toml files?

#2129 (comment)

Also you resolved this comment but you didn't address it (you should delete that note imo).

Later, you can cleanup the git history (e.g. squash all commits) and this should be ready to be merged.

@amustaque97 amustaque97 force-pushed the feat-2037-privision-environments branch 2 times, most recently from 3818167 to 9135917 Compare November 27, 2025 16:12
@marcoieni
Copy link
Member

Please add the comment to resolve #2127 (comment)

Also, I noticed that in the commit history there's a merge commit. Can you get rid of that by rebasing? 🙏

@amustaque97 amustaque97 force-pushed the feat-2037-privision-environments branch 2 times, most recently from 80a53a8 to 383c325 Compare November 27, 2025 17:43
Co-authored-by: Marco Ieni <11428655+marcoieni@users.noreply.github.com>
@amustaque97 amustaque97 force-pushed the feat-2037-privision-environments branch from c5c3ef2 to f8cd2d3 Compare November 28, 2025 06:27
@marcoieni
Copy link
Member

The dry run looks empty, which means that if we merge this there will be nothing applied. Which is what we want because it means we added all existing environments 🥳
merging this

@marcoieni marcoieni added this pull request to the merge queue Nov 28, 2025
Merged via the queue into rust-lang:main with commit 2d2858e Nov 28, 2025
6 checks passed
@marcoieni
Copy link
Member

I created #2132 as a follow up of this task if you are interested 😁

@amustaque97 amustaque97 deleted the feat-2037-privision-environments branch November 28, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provision environments from this repo

3 participants