-
Notifications
You must be signed in to change notification settings - Fork 332
feat: add support for [[environments]] block
#2127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for [[environments]] block
#2127
Conversation
Dry-run check results |
|
If you are changing the data structures, please make sure that the changes are not going to break serde deserialization (adding a field is fine; removing or renaming a field isn't). If you must do a breaking change to the format, make sure to coordinate it with all the users of the cc @Urgau |
marcoieni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. I left a few minor comments. After addressing them I will test this :)
1609c0d to
8f9f0ca
Compare
|
The dry run worked 🥳 Can you add these environments to the toml files? Also you resolved this comment but you didn't address it (you should delete that note imo). Later, you can cleanup the git history (e.g. squash all commits) and this should be ready to be merged. |
3818167 to
9135917
Compare
|
Please add the comment to resolve #2127 (comment) Also, I noticed that in the commit history there's a merge commit. Can you get rid of that by rebasing? 🙏 |
80a53a8 to
383c325
Compare
Co-authored-by: Marco Ieni <11428655+marcoieni@users.noreply.github.com>
c5c3ef2 to
f8cd2d3
Compare
|
The dry run looks empty, which means that if we merge this there will be nothing applied. Which is what we want because it means we added all existing environments 🥳 |
|
I created #2132 as a follow up of this task if you are interested 😁 |

closes #2037