Skip to content

publish libm via trusted publishing#2326

Merged
marcoieni merged 1 commit intomainfrom
publish-libm-via-trusted-publishing
Mar 17, 2026
Merged

publish libm via trusted publishing#2326
marcoieni merged 1 commit intomainfrom
publish-libm-via-trusted-publishing

Conversation

@marcoieni
Copy link
Member

No description provided.

crates = ["libm"]
publish-workflow = "publish.yaml"
publish-environment = "publish"
teams = ["libs"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libs team is an owner right now:

Image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly does this key do by the way?

Copy link
Member

@Kobzol Kobzol Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes the libs team an owner of the crate on crates.io. Which means that they can still manually do yanks without going through an admin or CI (new versions are only deployable through CI though).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, does setting up trusted publishing here take over what's currently on crates.io? Meaning only rust-lang-owner and rust-lang/libs will have permissions?

(Which is fine, Jorge hasn't been involved in a while)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we only sync team owners, not user owners.

branches = ["main"]

[[crates-io]]
crates = ["libm"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only public crate of the repo. You can verify by running this script:

https://github.com/rust-lang/team/blob/53e840af7c109c7148190abbd69a80ccbe69f653/docs/toml-schema.md#L494-L495

@marcoieni marcoieni marked this pull request as ready for review March 16, 2026 16:32
@github-actions
Copy link

Dry-run check results

[WARN  rust_team::sync] sync-team is running in dry mode, no changes will be applied.
[INFO  rust_team::sync] synchronizing crates-io
[INFO  rust_team::sync] 💻 Trusted Publishing Crate Diffs:
      Setting trusted publishing only option for krate `libm` to `true`

[INFO rust_team::sync] synchronizing github

@marcoieni marcoieni added this pull request to the merge queue Mar 17, 2026
Merged via the queue into main with commit 6d61e4b Mar 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants