delete disable-rulesets-repos config field#2433
Merged
Conversation
Dry-run check results |
marcoieni
force-pushed
the
delete-disable-rulesets-repos-config-field
branch
from
351d3a6 to
adbf39f
Compare
marcoieni
force-pushed
the
delete-disable-rulesets-repos-config-field
branch
from
adbf39f to
6a82ffb
Compare
marcoieni
commented
Apr 21, 2026
| fn should_use_rulesets(&self, _repo: &rust_team_data::v1::Repo) -> bool { | ||
| // TODO delete this function in the future since we don't need it anymore | ||
| true | ||
| } |
Member
Author
There was a problem hiding this comment.
I kept this function to minimize the size of this PR
marcoieni
requested review from
Mark-Simulacrum,
emilyalbini,
jdno and
ubiratansoares
as code owners
ubiratansoares
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need branch protections anymore since all repositories use rulesets now