.is_all_nan() returns true for an all-finite array

[sevberg]

It seems like calling .is_all_nan returns true when all values are NOT nan, and false otherwise. The below code reproduces the error for me

use ndarray::Array2;

fn main() {
    let mut arr_one = Array2::from_elem((10, 10), 1.0f32);
    assert!(arr_one.is_all_nan()); // Response it true, but should be false

    arr_one[(3, 3)] = f32::NAN;
    assert!(!arr_one.is_all_nan()); // Response is false, which is correct

    let arr_nan = Array2::from_elem((10, 10), f32::NAN);
    assert!(!arr_nan.is_all_nan()); // Response is false, but it should be true
}

[dbranford]

The logic in

ndarray/src/numeric/impl_float_maths.rs

Lines 11 to 31 in bd3ade9

	macro_rules! boolean_ops {
	($(#[$meta1:meta])* fn $func:ident
	$(#[$meta2:meta])* fn $all:ident
	$(#[$meta3:meta])* fn $any:ident) => {
	$(#[$meta1])*
	#[must_use = "method returns a new array and does not mutate the original value"]
	pub fn $func(&self) -> Array<bool, D> {
	self.mapv(A::$func)
	}
	$(#[$meta2])*
	#[must_use = "method returns a new boolean value and does not mutate the original value"]
	pub fn $all(&self) -> bool {
	$crate::Zip::from(self).all(|&elt| !elt.$func())
	}
	$(#[$meta3])*
	#[must_use = "method returns a new boolean value and does not mutate the original value"]
	pub fn $any(&self) -> bool {
	!self.$all()
	}
	};
	}

seems straightforwardly wrong, with .all(|&elt| !elt.$func()) rather than .all(|&elt| elt.$func()). It does make the corresponding is_any_nan() (!self.$all()) work, but I don't see why that shouldn't be $crate::Zip::from(self).any(|&elt| elt.$func()).