uefi: Make AtaDevice::execute_command() return AtaResponse on error #1828
+20
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seijikun
force-pushed
the
mr-atapassthru-lbamap
branch
from
9d6b65d to
9cd5238
Compare
phip1611
approved these changes
Nov 21, 2025
| .to_result_with_val(|| AtaResponse { req }) | ||
| .to_result() | ||
| }; | ||
| match result { |
Member
There was a problem hiding this comment.
nit. I think that .map() and .map_err(). But I don't have a strong opinion on that
Contributor
Author
There was a problem hiding this comment.
That doesn't work unfortunately, because both lambdas (map(..) and map_err(...)) would try to move/capture req. The match is ugly ... but it's the only way I found. :(
The AtaResponse contains status register values that help identifying what went wrong.
seijikun
force-pushed
the
mr-atapassthru-lbamap
branch
from
9cd5238 to
3e8685f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an AtaRequest fails, the drive sets status registers with information about what went wrong.
Currently, there was no way to access them. This now also returns the
AtaResponsestruct in the error case, so one can accessresponse.status().The other commit is something I would die for in hindsight.
Checklist