Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilisation of rand_core crate #386

Closed
isislovecruft opened this issue Apr 10, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@isislovecruft
Copy link

commented Apr 10, 2018

Hi! I'm sorry for creating an issue when this isn't one, but I wasn't sure how else to get in contact. Feel free to close. (Also my work email is isis@torproject.org and I'm in most of the Mozilla IRC rust channels as isis.)

In tor, we have C wrappers around OpenSSL's CSPRNG as well as some syscalls (when available). In order to avoid accidentally producing multiple CSPRNGs with the same state (we're using both C and Rust in the codebase right now, with some implementations duplicated/rewritten and others wrapped), we'd like to simply wrap our C code (tracking ticket). It seems like the best way to do this would be to implement traits from rand_core, especially since it's difficult for us to pull in extra dependencies (and we're not ready to switch over to any of your Rust implementations just yet, since we can't yet make Rust a mandatory compilation requirement).

Do you have any ideas when you might stabilise rand_core? Or perhaps put out a pre-release? Is there any way I can help with this process?

Thanks! and keep up all the great work!

@pitdicker

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2018

@dhardy Is does the releases, so I can only give my idea.

There is already a pre-release of rand_core, 0.1.0-pre.0. Combined with the pre-release of Rand 0.5 we got quite some feedback, and are mostly done working on that. But that is almost all for Rand, not for rand_core.

@dhardy: Would it make sense to release rand_core in a few days? We have two documentation PRs open, #381 and #381, and I am optimising the fill_bytes implementations a bit at the moment for small sizes, with a PR soon.

@dhardy

This comment has been minimized.

Copy link
Member

commented Apr 11, 2018

Yes, I think releasing 0.1.0 soon should be fine.

Doc updates and optimisations can potentially land as a point release anyway so no issues there.

Lets open a PR to bump the version numbers (and changelog/readme), then if nothing comes up for a couple of days I'll make that the release — unless you want to do the fill_bytes stuff first.

@pitdicker

This comment has been minimized.

Copy link
Collaborator

commented Apr 17, 2018

rand_core 0.1.0 is released 🎉.

@pitdicker pitdicker closed this Apr 17, 2018

@isislovecruft

This comment has been minimized.

Copy link
Author

commented Apr 18, 2018

Hooray! Thanks a bunch @pitdicker and @dhardy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.