Fix some clippy warnings

rand_chacha/src/guts.rs

@@ -101,6 +101,7 @@ impl ChaCha {
     }
 }
 
+#[allow(clippy::many_single_char_names)]
 #[inline(always)]
 fn refill_wide_impl<Mach: Machine>(
     m: Mach, state: &mut ChaCha, drounds: u32, out: &mut [u8; BUFSZ],

rand_core/src/lib.rs

@@ -35,7 +35,6 @@
 #![deny(missing_docs)]
 #![deny(missing_debug_implementations)]
 #![doc(test(attr(allow(unused_variables), deny(warnings))))]
-#![allow(clippy::unreadable_literal)]
 #![cfg_attr(doc_cfg, feature(doc_cfg))]
 #![no_std]
 

rand_distr/src/binomial.rs

@@ -12,6 +12,7 @@
 use crate::{Distribution, Uniform};
 use rand::Rng;
 use core::fmt;
+use core::cmp::Ordering;
 
 /// The binomial distribution `Binomial(n, p)`.
 ///
@@ -210,24 +211,28 @@ impl Distribution<u64> for Binomial {
                     let s = p / q;
                     let a = s * (n + 1.);
                     let mut f = 1.0;
-                    if m < y {
-                        let mut i = m;
-                        loop {
-                            i += 1;
-                            f *= a / (i as f64) - s;
-                            if i == y {
-                                break;
+                    match m.cmp(&y) {
+                        Ordering::Less => {
+                            let mut i = m;
+                            loop {
+                                i += 1;
+                                f *= a / (i as f64) - s;
+                                if i == y {
+                                    break;
+                                }
                             }
-                        }
-                    } else if m > y {
-                        let mut i = y;
-                        loop {
-                            i += 1;
-                            f /= a / (i as f64) - s;
-                            if i == m {
-                                break;
+                        },
+                        Ordering::Greater => {
+                            let mut i = y;
+                            loop {
+                                i += 1;
+                                f /= a / (i as f64) - s;
+                                if i == m {
+                                    break;
+                                }
                             }
-                        }
+                        },
+                        Ordering::Equal => {},
                     }
                     if v > f {
                         continue;

rand_distr/src/inverse_gaussian.rs

@@ -51,6 +51,7 @@ where
     StandardNormal: Distribution<F>,
     Standard: Distribution<F>,
 {
+    #[allow(clippy::many_single_char_names)]
     fn sample<R>(&self, rng: &mut R) -> F
     where R: Rng + ?Sized {
         let mu = self.mean;

rand_distr/src/weighted_alias.rs

@@ -261,7 +261,7 @@ where Uniform<W>: Clone
         Self {
             aliases: self.aliases.clone(),
             no_alias_odds: self.no_alias_odds.clone(),
-            uniform_index: self.uniform_index.clone(),
+            uniform_index: self.uniform_index,
             uniform_within_weight_sum: self.uniform_within_weight_sum.clone(),
         }
     }
@@ -299,7 +299,7 @@ pub trait AliasableWeight:
 
     /// Sums all values in slice `values`.
     fn sum(values: &[Self]) -> Self {
-        values.iter().map(|x| *x).sum()
+        values.iter().copied().sum()
     }
 }
 
@@ -324,7 +324,7 @@ macro_rules! impl_weight_for_float {
 /// rounding errors when there are many floating point values.
 fn pairwise_sum<T: AliasableWeight>(values: &[T]) -> T {
     if values.len() <= 32 {
-        values.iter().map(|x| *x).sum()
+        values.iter().copied().sum()
     } else {
         let mid = values.len() / 2;
         let (a, b) = values.split_at(mid);

rand_pcg/src/lib.rs

@@ -35,7 +35,6 @@
 )]
 #![deny(missing_docs)]
 #![deny(missing_debug_implementations)]
-#![allow(clippy::unreadable_literal)]
 #![no_std]
 
 #[cfg(not(target_os = "emscripten"))] mod pcg128;

src/lib.rs

@@ -53,9 +53,8 @@
 #![cfg_attr(feature = "nightly", feature(slice_partition_at_index))]
 #![cfg_attr(doc_cfg, feature(doc_cfg))]
 #![allow(
-    clippy::excessive_precision,
-    clippy::unreadable_literal,
-    clippy::float_cmp
+    clippy::float_cmp,
+    clippy::neg_cmp_op_on_partial_ord,
 )]
 
 #[cfg(feature = "std")] extern crate std;