Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getrandom to 0.2 #1041

Merged
merged 4 commits into from
Sep 15, 2020
Merged

Update getrandom to 0.2 #1041

merged 4 commits into from
Sep 15, 2020

Conversation

josephlr
Copy link
Member

Per discussion in #889, we are keeping getrandom optional. Users can now specify custom RNG handlers for getrandom on any target. However, not all users will want OsRng, so getrandom needs to be optional.

Signed-off-by: Joe Richey joerichey@google.com

Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr josephlr added this to the 0.8 release milestone Sep 10, 2020
@josephlr josephlr requested review from dhardy and vks and removed request for dhardy September 10, 2020 11:10
@dhardy
Copy link
Member

dhardy commented Sep 10, 2020

Thanks @josephlr.

The codes CUSTOM_START and INTERNAL_START can now be re-exported from getrandom I believe. But, see #984: we should probably document exactly what these values are and assert that they will never change.

@vks
Copy link
Collaborator

vks commented Sep 14, 2020

@dhardy I don't think we can re-export them as long as getrandom is an optional dependency. Instead, I documented the error codes as being identical to the ones in getrandom and added a test to make sure.

Signed-off-by: Joe Richey <joerichey@google.com>
@josephlr
Copy link
Member Author

@dhardy I don't think we can re-export them as long as getrandom is an optional dependency. Instead, I documented the error codes as being identical to the ones in getrandom and added a test to make sure.

Thanks! I also updated the comments to link to the getrandom documentation.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Joe Richey <joerichey@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants