Skip to content

Conversation

@uran0sH
Copy link
Contributor

@uran0sH uran0sH commented Apr 22, 2025

Summary of the PR

virtio-queue v0.15 introduces a new Descriptor API supporting both
split and packed virtqueue.
Update our dependencies and code to work with the new version
of the crate, including updating vhost-user-backend and virtio-vsock.

Updates vhost-user-backend from 0.18.0 to 0.19.0

Updates virtio-queue from 0.14.0 to 0.15.0

Updates virtio-vsock from 0.8.0 to 0.9.0

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

@uran0sH uran0sH force-pushed the change-api-dev branch 2 times, most recently from 001b1d0 to 7b33660 Compare April 23, 2025 15:06
@uran0sH uran0sH marked this pull request as ready for review April 23, 2025 15:07
@uran0sH uran0sH force-pushed the change-api-dev branch 7 times, most recently from 70be72c to 700c522 Compare April 25, 2025 13:41
@uran0sH uran0sH force-pushed the change-api-dev branch 8 times, most recently from 5538b91 to 92e1eab Compare April 25, 2025 15:47
@uran0sH
Copy link
Contributor Author

uran0sH commented Apr 25, 2025

@stefano-garzarella Hi, I have replaced the descriptor api for all vhost-devices. We might publish the new version of vm-virtio now.

@stefano-garzarella
Copy link
Member

@uran0sH LGTM, but please explain better in the commit description/PR what is changed and why we need it. Commit message are really important.

@stefano-garzarella
Copy link
Member

@stefano-garzarella Hi, I have replaced the descriptor api for all vhost-devices. We might publish the new version of vm-virtio now.

yeah, do you want to prepare a vm-virtio release?

@stefano-garzarella
Copy link
Member

@uran0sH now we published the new crates, can you update deps? (maybe you can just include in this PR the commit in #845 ).

@uran0sH uran0sH force-pushed the change-api-dev branch 10 times, most recently from e9b80df to 71ca28f Compare June 17, 2025 06:16
@uran0sH
Copy link
Contributor Author

uran0sH commented Jun 17, 2025

@uran0sH now we published the new crates, can you update deps? (maybe you can just include in this PR the commit in #845 ).

done

@stefano-garzarella
Copy link
Member

stefano-garzarella commented Jun 17, 2025

@uran0sH change looks good to me, but please write a better commit message and also update the PR title/description mentioning the new version, and the main changes.

Something like this:

chore: bump virtio-queue to v0.15

virtio-queue v0.15 introduces a new Descriptor API supporting both
split and packed virtqueue.
Update our dependencies and code to work with the new version of
the crate, including updating vhost-user-backend v0.19.

@uran0sH uran0sH changed the title change descriptor api chore: bump virtio-queue, vhost-user-backend and virtio-vscok Jun 19, 2025
virtio-queue v0.15 introduces a new Descriptor API supporting both
split and packed virtqueue.
Update our dependencies and code to work with the new version
of the crate, including updating vhost-user-backend and virtio-vsock.

Updates `vhost-user-backend` from 0.18.0 to 0.19.0
- [Release notes](https://github.com/rust-vmm/vhost/releases)
- [Commits](rust-vmm/vhost@vhost-user-backend-v0.18.0...vhost-user-backend-v0.19.0)

Updates `virtio-queue` from 0.14.0 to 0.15.0
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-queue-v0.14.0...virtio-queue-v0.15.0)

Updates `virtio-vsock` from 0.8.0 to 0.9.0
- [Release notes](https://github.com/rust-vmm/vm-virtio/releases)
- [Commits](rust-vmm/vm-virtio@virtio-vsock-v0.8.0...virtio-vsock-v0.9.0)

Signed-off-by: Wenyu Huang <huangwenyuu@outlook.com>
@uran0sH
Copy link
Contributor Author

uran0sH commented Jun 20, 2025

@uran0sH change looks good to me, but please write a better commit message and also update the PR title/description mentioning the new version, and the main changes.

Something like this:

chore: bump virtio-queue to v0.15

virtio-queue v0.15 introduces a new Descriptor API supporting both
split and packed virtqueue.
Update our dependencies and code to work with the new version of
the crate, including updating vhost-user-backend v0.19.

I have modified it. Could you review it again?

@stefano-garzarella stefano-garzarella enabled auto-merge (rebase) June 20, 2025 08:49
@stefano-garzarella
Copy link
Member

@uran0sH LGTM, thanks!

@stefano-garzarella
Copy link
Member

@epilys @stsquad @vireshk can you take a look?

@stefano-garzarella stefano-garzarella merged commit 91a6256 into rust-vmm:main Jun 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants