-
Notifications
You must be signed in to change notification settings - Fork 74
chore: bump virtio-queue, vhost-user-backend and virtio-vscok #834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
001b1d0 to
7b33660
Compare
70be72c to
700c522
Compare
5538b91 to
92e1eab
Compare
|
@stefano-garzarella Hi, I have replaced the descriptor api for all vhost-devices. We might publish the new version of vm-virtio now. |
|
@uran0sH LGTM, but please explain better in the commit description/PR what is changed and why we need it. Commit message are really important. |
yeah, do you want to prepare a vm-virtio release? |
e9b80df to
71ca28f
Compare
|
@uran0sH change looks good to me, but please write a better commit message and also update the PR title/description mentioning the new version, and the main changes. Something like this: |
virtio-queue v0.15 introduces a new Descriptor API supporting both split and packed virtqueue. Update our dependencies and code to work with the new version of the crate, including updating vhost-user-backend and virtio-vsock. Updates `vhost-user-backend` from 0.18.0 to 0.19.0 - [Release notes](https://github.com/rust-vmm/vhost/releases) - [Commits](rust-vmm/vhost@vhost-user-backend-v0.18.0...vhost-user-backend-v0.19.0) Updates `virtio-queue` from 0.14.0 to 0.15.0 - [Release notes](https://github.com/rust-vmm/vm-virtio/releases) - [Commits](rust-vmm/vm-virtio@virtio-queue-v0.14.0...virtio-queue-v0.15.0) Updates `virtio-vsock` from 0.8.0 to 0.9.0 - [Release notes](https://github.com/rust-vmm/vm-virtio/releases) - [Commits](rust-vmm/vm-virtio@virtio-vsock-v0.8.0...virtio-vsock-v0.9.0) Signed-off-by: Wenyu Huang <huangwenyuu@outlook.com>
I have modified it. Could you review it again? |
|
@uran0sH LGTM, thanks! |
Summary of the PR
virtio-queue v0.15 introduces a new Descriptor API supporting both
split and packed virtqueue.
Update our dependencies and code to work with the new version
of the crate, including updating vhost-user-backend and virtio-vsock.
Updates
vhost-user-backendfrom 0.18.0 to 0.19.0Updates
virtio-queuefrom 0.14.0 to 0.15.0Updates
virtio-vsockfrom 0.8.0 to 0.9.0Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.