Popup anchor system refinement - #4646
Open
Murmele wants to merge 19 commits into
Open
Conversation
8 tasks
Murmele
marked this pull request as ready for review
July 28, 2026 05:51
Murmele
requested review from
MarijnS95,
daxpedda,
jackpot51,
kchibisov and
madsmtm
as code owners
July 28, 2026 05:51
#Conflicts: # winit-appkit/src/window_delegate.rs # winit/src/changelog/unreleased.md
Murmele
commented
Aug 10, 2026
| /// attributes were set on a [`WindowType::Window`]. Gates the parent-relative coordinate | ||
| /// frame used when applying anchor/gravity/positioner-offset changes. | ||
| anchored: bool, | ||
| popup_positioner: RefCell<WindowPositioner>, |
Contributor
Author
There was a problem hiding this comment.
Rename to positioner in general
| self.emit_move_event(); | ||
| // `windowDidMove:` isn't triggered when a move is part of a resize (e.g. dragging the | ||
| // top or left edge), so popups need repositioning here too. | ||
| self.reposition_child_popups(); |
Contributor
Author
There was a problem hiding this comment.
reposition_child_windows()
Murmele
commented
Aug 10, 2026
| constraint_adjustment: WindowConstraintAdjustment, | ||
| (anchor_position, anchor_size): (LogicalPosition<f64>, LogicalSize<f64>), | ||
| offset: LogicalPosition<f64>, | ||
| popup_size: LogicalSize<f64>, |
Contributor
Author
There was a problem hiding this comment.
rename to window_size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement possibility to change the anchor properties of a popup on wayland and imitate the behaviour for other platforms which do not support such anchoring system
changelogmodule if knowledge of this change could be valuable to usersTested on:
X11Does not support popups