Skip to content

Comments

Update cocoa and core-graphics#608

Merged
asterbloom merged 3 commits intorust-windowing:masterfrom
paulrouget:dependencies_update
Aug 2, 2018
Merged

Update cocoa and core-graphics#608
asterbloom merged 3 commits intorust-windowing:masterfrom
paulrouget:dependencies_update

Conversation

@paulrouget
Copy link
Contributor

@paulrouget paulrouget commented Jul 21, 2018

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created an example program if it would help users understand this functionality

@mitchmindtree
Copy link
Contributor

mitchmindtree commented Jul 21, 2018

While I look forward to the benefits of updating these deps, I would consider this to be a breaking change and I do not think it is safe to bump the tiny version as this can easily break downstream code that may depend on these dependencies from more than one upstream crate. I have been burned by this far too many times. IMO this should not be published until v0.17.0.

@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 21, 2018

I can change the version to 0.17.

@paulrouget paulrouget force-pushed the dependencies_update branch from 4334a8d to 1fbdd79 Compare July 21, 2018 11:02
@paulrouget paulrouget mentioned this pull request Jul 21, 2018
Merged
@asterbloom asterbloom added the DS - appkit Affects the AppKit/macOS backend label Jul 21, 2018
@paulrouget paulrouget mentioned this pull request Jul 23, 2018
Merged
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 23, 2018

(i've updated the version number)

@asterbloom
Copy link
Member

asterbloom commented Jul 25, 2018

Thanks for the PR. I'll merge this after the other open PRs.

@paulrouget paulrouget force-pushed the dependencies_update branch from 1fbdd79 to 0a63dcf Compare July 27, 2018 03:19
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 27, 2018

Fixed the conflicts.

@paulrouget paulrouget force-pushed the dependencies_update branch from 0a63dcf to e179261 Compare July 30, 2018 03:45
@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 30, 2018

Fixed the conflicts.

@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 30, 2018

@francesca64 is the travis failure expected or did my PR introduced it?

@paulrouget
Copy link
Contributor Author

paulrouget commented Jul 30, 2018

Just saw AltF02/x11-rs#88

@francesca64 can we land or do we need to fix this issue first?

@asterbloom
Copy link
Member

asterbloom commented Jul 30, 2018

I've been merging PRs with this build failure all week, sadly. That said, I'm waiting for the fix for #607 before making a new release.

@felixrabe
Copy link
Contributor

felixrabe commented Jul 30, 2018

#618

@paulrouget paulrouget mentioned this pull request Aug 1, 2018
Merged
4 tasks
@Eijebong
Copy link
Contributor

Eijebong commented Aug 2, 2018

Any chance this could get merged now ? :)

@asterbloom
Copy link
Member

asterbloom commented Aug 2, 2018

Yep! Sorry you had to wait so long.

@asterbloom asterbloom merged commit a32f7f2 into rust-windowing:master Aug 2, 2018
@felixrabe
Copy link
Contributor

felixrabe commented Aug 2, 2018

Thank you for your hard work here @francesca64. Very much appreciated!

@felixrabe felixrabe mentioned this pull request Aug 2, 2018
Closed
@Eijebong
Copy link
Contributor

Eijebong commented Aug 2, 2018

No problem.😃 Thanks a lot

bors-servo pushed a commit to servo/servo that referenced this pull request Aug 6, 2018
Auto merge of #21223 - paulrouget:wrupdate, r=gw3583
2a0eec4 
Webrender update

Requires:

- ~winit PR: rust-windowing/winit#608
- ~glutin PR: rust-windowing/glutin#1047
- ~skia PR: servo/skia#164
- ~azure PR: servo/rust-azure#291
- ~WR PR: servo/webrender#2923
- ~offscreen gl context PR: servo/surfman#127
- ~plane-split PR: servo/plane-split#14
- ~pathfinder: https://github.com/pcwalton/pathfinder/pull/92~

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21223)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

DS - appkit Affects the AppKit/macOS backend

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@paulrouget @mitchmindtree @asterbloom @felixrabe @Eijebong