Skip to content

Implement GetFileSizeEx compatibility wrapper#62

Merged
seritools merged 1 commit into
rust9x:rust9xfrom
Jookia:jookia_copyfile
Jul 2, 2026
Merged

Implement GetFileSizeEx compatibility wrapper#62
seritools merged 1 commit into
rust9x:rust9xfrom
Jookia:jookia_copyfile

Conversation

@Jookia

@Jookia Jookia commented Jul 1, 2026

Copy link
Copy Markdown

Windows before 2000 lacks GetFileSizeEx which Rust relies on. Implement a compatibility function that uses GetFileSize as a backup.

Comment thread library/std/src/sys/pal/windows/c.rs
@Jookia Jookia force-pushed the jookia_copyfile branch from 8753d8e to 2f48cdf Compare July 2, 2026 16:19

@seritools seritools left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, i didn't actually submit my comment, the longer one was from before ^^

Comment thread library/std/src/sys/pal/windows/c.rs
Comment thread library/std/src/sys/pal/windows/c.rs Outdated
Windows before 2000 lacks GetFileSizeEx which Rust relies on.
Implement a compatibility function that uses GetFileSize as a backup.
@Jookia Jookia force-pushed the jookia_copyfile branch from 2f48cdf to cce566b Compare July 2, 2026 16:32
@seritools seritools merged commit ed557a8 into rust9x:rust9x Jul 2, 2026
2 of 11 checks passed
@Jookia Jookia deleted the jookia_copyfile branch July 2, 2026 16:36

@cher-nov cher-nov left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excuse me, but seems like you've accidentally lost an assignment to *lpfilesize now...

@seritools

Copy link
Copy Markdown
Member

oh true lol

@Jookia

Jookia commented Jul 2, 2026

Copy link
Copy Markdown
Author

Oops, good catch. Sorry! #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants