Skip to content

test(cp): cover symlink file download destination#255

Merged
overtrue merged 1 commit into
mainfrom
automation/test-gap-detection-20260712
Jul 11, 2026
Merged

test(cp): cover symlink file download destination#255
overtrue merged 1 commit into
mainfrom
automation/test-gap-detection-20260712

Conversation

@overtrue

@overtrue overtrue commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add a focused regression test for recursive download destination hardening when the final target file is a symlink.
  • Covers the adjacent branch added by recent download safety hardening; existing coverage only checked symlink directory components.

Validation

  • cargo test -p rustfs-cli download_destination_rejects_existing_symlink_file
  • cargo fmt --all --check
  • make pre-commit

@overtrue overtrue marked this pull request as ready for review July 11, 2026 21:16
Copilot AI review requested due to automatic review settings July 11, 2026 21:16
Copilot AI reviewed Jul 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@overtrue overtrue merged commit f595ae1 into main Jul 11, 2026
16 checks passed
@overtrue overtrue deleted the automation/test-gap-detection-20260712 branch July 11, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@overtrue