fix(admin): decode beta.9 response envelopes#260
Merged
Conversation
cxymds
marked this pull request as ready for review
July 17, 2026 02:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Background
RustFS 1.0.0-beta.9 wraps
/rustfs/admin/v3/infoin aninfofield and targeted/rustfs/admin/v3/pools/statusresponses in apoolfield. The CLI previously deserialized those envelopes directly into default-valued domain models, so the commands succeeded while displaying empty cluster or pool data.Root cause
ClusterInfoandPoolStatususe Serde defaults and accept unknown fields. The new beta.9 envelope fields were ignored, producing default domain objects instead of a deserialization error.Solution
infoenvelope before returningClusterInfopoolenvelope before returning targetedPoolStatusUser impact
rc admin info cluster,rc admin info server,rc admin info disk, and targetedrc admin pool statusnow display the data returned by RustFS beta.9.Validation
cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspace