feat(rc-admin)!: add safe RustFS KMS key lifecycle mutations#279
Draft
cxymds wants to merge 1 commit into
Draft
Conversation
Member
Author
|
Validation is complete for commit
The PR base has been restored to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Resolves rustfs/backlog#1395
Part of rustfs/backlog#1378
Roadmap: rustfs/backlog#1361
Background
After read-only KMS inspection in #278, RustFS administrators need explicit key lifecycle mutations that use the native beta.10 Admin API without exposing key material. Deletion must remain non-accidental, and inconsistent server error payloads must not leak into CLI diagnostics.
This PR is stacked on #278 so the mutation surface remains independently reviewable.
Solution
rc admin kms key create ALIAS [--name] [--description] [--tag KEY=VALUE]--yes--yesand--confirm-immediaterc admin kms key cancel-deletion ALIAS KEY_IDSecurity
The CLI never calls a data-key generation/export route. Request diagnostics do not include mutation bodies, and response adapters select only known metadata fields. Immediate deletion has a second explicit acknowledgement because it cannot be cancelled.
Compatibility
BREAKING contract marker: this extends the protected CLI reference and output-v3 KMS contract with lifecycle mutation operations. Existing output-v1 and output-v2 contracts remain unchanged.
Validation
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceAll checks pass locally. Native route and request contracts are covered with signed mock Admin servers; a live configured-KMS environment is still recommended before merge.