feat(admin): classify RustFS diagnostic capabilities#282
Closed
cxymds wants to merge 2 commits into
Closed
Conversation
Member
Author
|
Validation complete at exact head f6e9316.
The first advisory attempt failed before checkout while Docker Hub timed out resolving the pinned cargo-deny action base image. Re-running only the failed job succeeded without a code or dependency change. The PR remains correctly stacked on #268 and performs no active diagnostic request. |
Base automatically changed from
cxymds/issue-1363-capabilities
to
cxymds/issue-1362-output-v3
July 22, 2026 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes rustfs/backlog#1403
Parent: rustfs/backlog#1383
Roadmap: rustfs/backlog#1361
Background and user impact
RustFS 1.0.0-beta.10 registers several diagnostic routes that are placeholders rather than real measurements. Route presence and HTTP 200 responses are therefore not sufficient evidence of support. Without probe-specific truth, rc could advertise or execute object, network, site, or site-replication performance tests that return misleading success.
The existing /v3/inspect-data endpoint also returns reconstructed object bytes and is not an inspect archive.
Root cause
Runtime discovery exposed broad server capabilities but did not normalize individual diagnostic probe states or provide a reusable fail-closed guard. Unknown future server versions could not be distinguished safely from the pinned beta.10 contract.
Solution
Validation
Passed locally at exact head f6e9316:
Focused rc-core and rc-s3 capability tests also pass.
Review notes
This PR is intentionally stacked on #268 because it extends runtime capability discovery and output schema v3 foundations. It adds no diagnostic command and performs no active probe. Unknown versions remain fail-closed until a server-owned per-probe contract is available through rustfs/backlog#1402.
BREAKING process
BREAKING marker for the stacked exact-head workflow: temporary validation against main includes protected command-reference/schema changes from prerequisite PRs #266 and #268. This #1403 diff against its true #268 base changes only capability core/S3 code and does not independently modify a protected file. The prerequisite output-v3 stack carries its documented additive contract and migration boundary.