feat(copy-core): add multipart server-side copy primitive - #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes rustfs/backlog#1440
Parent roadmap: rustfs/backlog#1370
Depends on the version-aware object support delivered for rustfs/backlog#1369.
Background
The existing single-request copy path cannot copy objects above the S3 CopyObject limit. Recursive remote copy therefore needs a reusable multipart server-side copy primitive in the core ObjectStore boundary and the S3 backend.
Root cause
The core abstraction exposed only single-request copy. It had no multipart copy planner, typed cancellation path, per-part CopySourceRange support, or guaranteed abort handling for failures during an active multipart upload.
Solution
Cancellation boundary
Guaranteed cleanup uses the explicit cooperative MultipartCopyCancellation token. Directly dropping the entire future cannot run asynchronous abort cleanup; callers that need cancellation guarantees must signal the token and await the operation result.
Validation
The follow-up rustfs/backlog#1439 will consume this primitive for recursive same-endpoint remote copy.