feat(transfer): support truthful destination storage classes - #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes rustfs/backlog#1457
Background
cp --storage-classandpipe --storage-classwere parsed but rejected unconditionally. The S3 transfer model can now carry destination storage class, while RustFS beta.10 has meaningful single-request behavior only for STANDARD and REDUCED_REDUNDANCY.Root cause
The S3 adapter did not map storage class onto PutObject or CopyObject, command paths still used legacy methods, and multipart paths could not truthfully guarantee persistence. InvalidStorageClass also fell through to a generic network error.
Solution
cpsingle/planned upload and server-side copy paths pluspipeto advanced optionsMultipart persistence remains tracked by rustfs/backlog#1464; broader capability truthfulness remains tracked by rustfs/backlog#1465.
Validation
cargo fmt --all --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspace