feat(completions): add safe user-level install - #313
Merged
Conversation
cxymds
marked this pull request as ready for review
July 24, 2026 11:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--installsupport torc completions--force--install-dirusageWhy
Completion generation already exists, but users must manually discover the correct location and install the generated script. This implements the completion-install slice of rustfs/backlog#1382 while keeping stdout generation unchanged.
User impact
Users can run
rc completions <shell> --install. Existing files are never overwritten implicitly;--forceis required to replace them.BREAKING change assessment
BREAKING: no. This only adds optional flags; the existing
rc completions <shell>stdout behavior is unchanged. The marker is included because this PR updates the protected command reference documentation.Validation
cargo fmt --checkcargo test -p rustfs-cli commands::completions::tests(7 tests in each CLI target)cargo clippy -p rustfs-cli --all-targets -- -D warningsCloses rustfs/backlog#1484
Refs rustfs/backlog#1382