feat(replication): add typed metrics and MRF inspection - #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typed status and aggregate MRF contracts
rc bucket replication mrf ALIAS/BUCKETand expose the same commandthrough the
replicatecompatibility surfacelatency and bandwidth scopes, runtime/durable MRF availability, and partial
target observations
legacy_unknowninstead ofinferring a healthy zero backlog
and response bucket identity without inventing target queues, uptime,
per-object rows, or unavailable per-target durable records
missing configuration/bucket, unsupported, malformed, and oversized errors
control-character redaction
Compatibility
This is an additive output-v3 extension: the existing replication diff variant
and fixtures remain valid.
schemas/output_v1.jsonand the protected commandreference are unchanged. Older server responses remain readable but are
explicitly classified as
legacy_unknownwhere they lack truth metadata.During a rolling RustFS upgrade, incomplete node aggregation is rendered as
partial rather than a complete healthy snapshot.
Validation
cargo fmt --all --checkcargo clippy --workspace -- -D warningscargo test --workspace --quietHTTP/error bounds, security/redaction, output compatibility, and QA/operations
Dependency
The authoritative service-side truth contract is implemented by
rustfs/rustfs#5209 and rustfs/backlog#1413. Merge this PR after that dependency.
Closes rustfs/backlog#1414
Related: rustfs/backlog#1409, rustfs/backlog#1381, rustfs/backlog#1361