feat(diagnostics): retrieve encrypted inspect archives - #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes rustfs/backlog#1497
Related: rustfs/backlog#1401, rustfs/backlog#1383, rustfs/backlog#1361
Summary of Changes
rc admin diagnostics inspect-archive ALIAS/BUCKET/OBJECT --output FILE.Security and Reliability
persist_noclobber; existing and symlink destinations are rejected, including nested output-directory symlink components.Verification
cargo fmt --all -- --checkcargo clippy --workspace -- -D warningscargo test -p rc-core inspect_archive -- --nocapture(6 passed)cargo test -p rc-s3 inspect_archive -- --nocapture(4 passed)cargo test -p rustfs-cli inspect_archive -- --nocapture(7 tests in each CLI binary)cargo test --workspace(all workspace unit, integration, schema, help-contract, and doc tests passed)Adversarial review verdicts:
Compatibility
This is an opt-in command for RustFS servers advertising
admin.diagnostics.inspect-archive. Older RustFS and non-RustFS aliases fail with an actionable capability error before a route request. Existing inspection commands and legacy v3 inspect behavior remain unchanged.Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md). If this is your first contribution, review the CLA document and sign it by commenting
I have read and agree to the CLA.on the PR.