fix(lifecycle): preserve expiration days with marker cleanup#170
Merged
Conversation
cxymds
marked this pull request as ready for review
July 17, 2026 09:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Fix lifecycle rule creation so enabling expired delete-marker cleanup no longer replaces the configured current-version expiration days. The form now emits the
Expiration.Daysrule and theExpiredObjectDeleteMarkerrule separately in one lifecycle configuration update, preserves suspended-versioning behavior, validates incomplete or incompatible tag filters, and enforces the S3 1000-rule limit.Type of Change
Testing
pnpm type-check pnpm lint pnpm prettier --check . pnpm test:run pnpm buildChecklist
Related Issues
Fixes rustfs/rustfs#4963
Companion RustFS change: rustfs/rustfs#4974
Screenshots (if applicable)
N/A. The local app required an authenticated RustFS session, so the lifecycle dialog could not be exercised visually without bypassing authentication.
Additional Notes
The AWS SDK serialization regression test verifies that
DaysandExpiredObjectDeleteMarkerare emitted in two separate lifecycle rules.