Skip to content

fix: distinguish filtered object empty states - #184

Merged
cxymds merged 1 commit into
mainfrom
cxymds/fix-object-filter-empty-state
Jul 26, 2026
Merged

fix: distinguish filtered object empty states#184
cxymds merged 1 commit into
mainfrom
cxymds/fix-object-filter-empty-state

Conversation

@cxymds

@cxymds cxymds commented Jul 26, 2026

Copy link
Copy Markdown
Member

Summary

  • distinguish a genuinely empty bucket from an empty client-side filter result
  • show separate states while additional object batches are loading or remain unsearched
  • add localized copy across all Console locales
  • add unit and source-level regression coverage for the object-list state contract

Root cause

The object browser filtered only the objects already loaded in the client, but always reused the genuine empty-bucket copy when that filtered set was empty. This could incorrectly tell operators that a populated bucket had no objects.

User impact

Filtered searches no longer display the empty-bucket upload prompt. The UI now explains whether more objects remain unsearched or whether all loaded objects have been checked.

Closes #183

Validation

  • pnpm install --frozen-lockfile
  • pnpm test:run (367/367 passed)
  • pnpm tsc --noEmit
  • pnpm lint
  • git diff origin/main --check
  • changed files pass Prettier

Repository-wide pnpm prettier --check . still reports the existing formatting issue in app/(dashboard)/sse/page.tsx; that file is unchanged by this PR.

@cxymds
cxymds marked this pull request as ready for review July 26, 2026 10:21
@cxymds
cxymds merged commit 1f21323 into main Jul 26, 2026
10 checks passed
@cxymds
cxymds deleted the cxymds/fix-object-filter-empty-state branch July 26, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Console browser: page-scoped filter renders misleading "No Objects" empty-bucket state for objects on other pages

1 participant