Skip to content

fix(status): honor active first scanner cycle - #192

Merged
overtrue merged 1 commit into
rustfs:mainfrom
marshawcoco:fix/scanner-active-first-cycle-status
Aug 2, 2026
Merged

fix(status): honor active first scanner cycle#192
overtrue merged 1 commit into
rustfs:mainfrom
marshawcoco:fix/scanner-active-first-cycle-status

Conversation

@marshawcoco

Copy link
Copy Markdown
Contributor

Pull Request

Description

RustFS reports current_cycle_active separately because scanner cycle ID 0 is a valid active first cycle. The Running Status page previously inferred activity only from current_cycle > 0, so an active first cycle was displayed as Never run.

This change preserves the explicit activity field during metrics normalization and treats it as authoritative. When the field is absent, the Console retains the legacy nonzero-cycle fallback for compatibility with older RustFS nodes.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Testing

  • Unit tests added/updated
  • Manual testing completed
pnpm install --frozen-lockfile
pnpm test:run
pnpm type-check
pnpm lint
pnpm format:check

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing tests pass
  • No new dependencies added, or they are justified

Related Issues

Related to rustfs/rustfs#5163.

Screenshots (if applicable)

N/A. The change corrects the status derived from the existing metrics response without changing layout or styling.

Additional Notes

The explicit field was added by rustfs/rustfs#5397. The fallback keeps the Console compatible with RustFS versions that do not yet emit it.

@overtrue
overtrue merged commit 6b48919 into rustfs:main Aug 2, 2026
10 checks passed
@marshawcoco
marshawcoco deleted the fix/scanner-active-first-cycle-status branch August 2, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants