ci: change the docker build trigger condition#163
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bad0d182a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| workflow_run: | ||
| workflows: [ "Continuous Integration" ] | ||
| types: [ completed ] | ||
| release: | ||
| types: [published] |
There was a problem hiding this comment.
For a published release, this workflow does not subscribe to the release event: GitHub Actions documents release and workflow_run as separate top-level events and shows the published-release syntax as on: release: types: [published] (checked GitHub Actions event docs for .github/workflows/docker.yml). Nesting release under workflow_run leaves the Docker publish workflow tied to workflow-run semantics instead of release publishes; the job guard below also only allows workflow_dispatch/workflow_run, so a corrected release trigger must be allowed there or release-published runs will be skipped.
Useful? React with 👍 / 👎.
2 participants
Type of Change
Related Issues
Summary of Changes
Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](if user-visible change)Impact
Verification
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.