Skip to content

ci: change the docker build trigger condition #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GatewayJ merged 1 commit into from
Jul 7, 2026
Merged

ci: change the docker build trigger condition #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ name: Publish Docker Image

on:
workflow_run:
workflows: [ "Continuous Integration" ]
types: [ completed ]
release:
types: [published]
Comment on lines 18 to +20

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Put release back at the top-level trigger

For a published release, this workflow does not subscribe to the release event: GitHub Actions documents release and workflow_run as separate top-level events and shows the published-release syntax as on: release: types: [published] (checked GitHub Actions event docs for .github/workflows/docker.yml). Nesting release under workflow_run leaves the Docker publish workflow tied to workflow-run semantics instead of release publishes; the job guard below also only allows workflow_dispatch/workflow_run, so a corrected release trigger must be allowed there or release-published runs will be skipped.

Useful? React with 👍 / 👎.

workflow_dispatch:
inputs:
version:
Expand Down Expand Up @@ -48,7 +48,7 @@ jobs:
if [ "${{ github.event_name }}" = "workflow_dispatch" ]; then
RAW="${{ github.event.inputs.version }}"
else
RAW="${{ github.event.workflow_run.head_branch }}"
RAW="${{ github.event.release.tag_name }}"
fi
RAW_TAG="${RAW#refs/tags/}"
VERSION="${RAW_TAG#v}"
Expand Down