fix(s3select): enforce query and resource limits - #5028
Merged
Conversation
Contributor
|
CLA requirements are satisfied for this pull request. |
GatewayJ
force-pushed
the
fix/s3-select-query-limits
branch
from
July 22, 2026 08:29
68d9451 to
14b2b67
Compare
Member
Author
GatewayJ
requested review from
houseme and
overtrue
and removed request for
overtrue
July 22, 2026 08:48
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14b2b67346
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
GatewayJ
force-pushed
the
fix/s3-select-query-limits
branch
3 times, most recently
from
July 24, 2026 14:17
2f7d8a5 to
1e0eace
Compare
GatewayJ
force-pushed
the
fix/s3-select-query-limits
branch
from
July 24, 2026 15:34
1e0eace to
545fbdc
Compare
GatewayJ
marked this pull request as ready for review
July 25, 2026 03:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
N/A
Summary of Changes
GROUP BY,ORDER BY, aliases, andCOUNT(*)behavior.Busy.Verification
cargo fmt --all --checkcargo test -p rustfs-s3select-api(62 passed)cargo test -p rustfs-s3select-query(108 passed, 2 ignored)cargo test -p rustfs app::select_object::tests::(21 passed)make pre-commitmake pre-pr(10,047 tests passed, 138 skipped; doctests passed)Impact
S3 Select now reports deterministic
Busyresponses for query deadlines and resource exhaustion even when delivery is backpressured. Corrupt or truncated JSON/raw streams fail instead of silently returning partial data, while object-store bounded range semantics remain compatible when the requested end exceeds EOF.CSV values continue to be inferred as strings, preserving leading zeros and existing header behavior. Queries that need numeric ordering must use an explicit cast. No on-disk or wire format changes are introduced.
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md). If this is your first contribution, review the CLA document and sign it by commenting
I have read and agree to the CLA.on the PR.