fix(s3): complete CopyObject checksum support - #5178
Merged
Conversation
Contributor
|
CLA requirements are satisfied for this pull request. |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Refs rustfs/backlog#1466.
Summary of Changes
s3sto8136db4ac8253c0ccfd86f8216e00e0235747757, which exposes the additional CopyObject checksum result fieldsCOMPOSITEchecksum semanticsInvalidArgumentbefore source lookup, locking, or destination mutationVerification
make pre-commitcargo fmt --all --checkcargo clippy -p rustfs-rio --all-targets -- -D warningscargo clippy -p rustfs --all-targets -- -D warningscargo clippy -p e2e_test --all-targets -- -D warningscargo nextest run -p rustfs classify_response_checksums_splits_typed_and_extra(1 passed)cargo nextest run -p e2e_test copy_object_checksum_test(7 passed)make pre-prguard, workspace clippy, script-test, and workspace nextest phases (10,184 passed; 139 skipped)cargo test --all --docphase was intentionally skipped per maintainer directionImpact
CopyObject now returns and persists all ten supported checksum algorithms consistently. Requests for unsupported checksum algorithms fail with HTTP 400 without modifying an existing destination object. No configuration or migration is required.
The implementation does not by itself satisfy the release-boundary acceptance criterion in rustfs/backlog#1466. That issue should remain open until a RustFS release containing this change is published and its release notes identify the first compatible version.
Additional Notes
The change was independently reviewed against correctness, security, performance, test coverage, maintainability, compatibility, and simplicity roles. The multipart checksum type and validation-precedence findings from that review are covered by regression tests.