test(ilm): cover durable transition progress recovery - #5286
Merged
Conversation
Co-Authored-By: heihutu <heihutu@gmail.com>
Contributor
|
CLA requirements are satisfied for this pull request. |
houseme
marked this pull request as ready for review
July 26, 2026 09:14
houseme
enabled auto-merge (squash)
July 26, 2026 09:14
…durable-checkpoint-slice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Related to rustfs/backlog#1479.
Summary of Changes
Adds a focused store-level regression test for durable manual transition progress checkpoints. The test persists a running async job checkpoint with an opaque continuation token, reloads the job record from system metadata, simulates owner loss by expiring the reloaded lease, and verifies recovery fails closed as
Unknownwith page/task journal context while releasing scope admission.This is intentionally test-only and does not change production behavior.
Verification
cargo fmt --allcargo fmt --all --checkgit diff --checkcargo test -p rustfs-ecstore manual_transition_progress_checkpoint_survives_reload_and_recovery --lib -- --nocapturemake pre-commitwas not run locally; this PR is opened as Draft and leaves broad validation to CI before readiness.Impact
No user-facing, API, configuration, or compatibility impact. Test-only coverage for manual transition durable checkpoint/recovery semantics.
Additional Notes
Adversarial validation: correctness attacked checkpoint persistence, reload, owner-loss recovery, and scope-admission release; no break found. Simplicity attacked a pure record-level alternative, but that would not cover durable store reload or recovery integration, so the store-level test is the smallest useful slice.