test(lifecycle): add manual transition rollout harnesses - #5346
Merged
Conversation
Add a dedicated #1508 ignored E2E harness for non-empty manual transition rollout readback and a reusable Docker mixed-version harness entrypoint. Co-Authored-By: heihutu <heihutu@gmail.com>
Contributor
|
CLA requirements are satisfied for this pull request. |
Use unwrap_or_default for the optional transition_failed report field while preserving the zero-default status readback behavior. Co-Authored-By: heihutu <heihutu@gmail.com>
houseme
marked this pull request as ready for review
July 27, 2026 23:37
houseme
enabled auto-merge (squash)
July 27, 2026 23:38
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
#1508
Summary of Changes
Add an ignored four-node E2E harness that exercises a non-empty manual transition rollout, verifies successful terminal status, checks that transitioned objects reach the cold tier, and confirms job status readback after a rollout node restart.
Add a reusable Docker mixed-version manual transition harness for external #1508 evidence collection, including old/new/cold image selection, object count, rollback-node replacement, status polling, log capture, and summary artifact generation.
Wire the new Docker harness into the runbook smoke test and document it in the scripts index.
Verification
cargo fmt --allcargo fmt --all --checkmake pre-commitbash -n scripts/manual_transition_mixed_version_docker_harness.sh && scripts/test_manual_transition_runbooks.shcargo test -p e2e_test four_node_manual_transition_rollout_non_empty_restart_readback -- --ignored --nocaptureImpact
No production behavior change. This adds repeatable validation coverage and operator-facing evidence collection for manual transition mixed-version rollout scenarios.
Additional Notes
The ignored E2E harness intentionally keeps the positive rollout path separate from remote-tier failure injection so #1508 evidence is not conflated with #1509 failure attribution scenarios.