fix(bitrot): reject trailing shard data - #5358
Merged
Merged
Conversation
Contributor
|
CLA requirements are satisfied for this pull request. |
cxymds
marked this pull request as ready for review
July 28, 2026 09:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes rustfs/backlog#1518.
Summary of Changes
Verification
rustfmt --edition 2024 --check crates/ecstore/src/erasure/coding/bitrot.rs crates/ecstore/src/set_disk/ops/bitrot_self_verify.rsgit diff --checkImpact
PUT post-write verification now validates the complete reader rather than only the expected-length prefix. Each verification adds one single-byte EOF probe and no second full scan.
Additional Notes
The MinIO streaming layout, encoded-size formula, legacy format, and on-disk representation are unchanged.
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md). If this is your first contribution, review the CLA document and sign it by commenting
I have read and agree to the CLA.on the PR.