Skip to content

ci(s3select-query): inherit workspace lint policy - #5443

Merged
overtrue merged 1 commit into
mainfrom
codex/backlog-1550-s3select-query-workspace-lints
Jul 29, 2026
Merged

ci(s3select-query): inherit workspace lint policy#5443
overtrue merged 1 commit into
mainfrom
codex/backlog-1550-s3select-query-workspace-lints

Conversation

@overtrue

Copy link
Copy Markdown
Collaborator

Related Issues

Fixes rustfs/backlog#1550.

Summary of Changes

  • Opt rustfs-s3select-query into the workspace lint policy.
  • Remove the redundant TableReference clone reported after enabling the policy.

Verification

  • cargo fmt --all --check
  • cargo clippy -p rustfs-s3select-query --all-targets --all-features -- -D warnings
  • cargo nextest run -p rustfs-s3select-query --all-features (126 passed, 2 skipped)
  • make pre-commit

Impact

No runtime, API, configuration, or compatibility behavior changes. The crate now follows the repository's existing workspace lint policy.

Additional Notes

The test linker emitted a macOS compact-unwind performance warning; the test command completed successfully and no source warning or test failure was reported.


Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md). If this is your first contribution, review the CLA document and sign it by commenting I have read and agree to the CLA. on the PR.

Copilot AI review requested due to automatic review settings July 29, 2026 15:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

CLA requirements are satisfied for this pull request.

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@overtrue
overtrue enabled auto-merge (squash) July 29, 2026 15:25
@overtrue
overtrue disabled auto-merge July 29, 2026 15:31
@overtrue
overtrue merged commit 94ee597 into main Jul 29, 2026
10 of 18 checks passed
@overtrue
overtrue deleted the codex/backlog-1550-s3select-query-workspace-lints branch July 29, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants