fix(admin): fail closed for empty server context slots - #5452
Merged
Conversation
Contributor
|
CLA requirements are satisfied for this pull request. |
overtrue
enabled auto-merge (squash)
July 29, 2026 20:17
overtrue
disabled auto-merge
July 29, 2026 23:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Fixes rustfs/backlog#1553
Summary of Changes
Verification
cargo fmt --all --checkcargo test -p rustfs --lib admin::runtime_sources::testscargo test -p rustfs --test embedded_multi_instance_test --features e2e-test-hooks --no-runmake pre-commitImpact
During the brief embedded-server startup window, non-public requests now return HTTP 503 instead of resolving another server's process-global context. Public health endpoints remain available.
Additional Notes
The local full
make pre-prsuite cannot be meaningfully completed because this host's transparent proxy intercepts embedded127.0.0.1test traffic. CI runs the integration test in a clean environment and remains required.