fix: accept an empty backup as-path - #1840
Draft
magrathean-uk wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows an explicitly empty
--as-pathvalue and adds unit and integration regression coverage.Why
Clap's default path parser rejected an empty argument before rustic could apply its existing snapshot-path semantics. The parser now preserves the empty path value for the command to handle.
Validation
cargo test --locked --lib commands::backup::tests::as_path_accepts_an_empty_cli_valuecargo test --locked --test backup_restore backup_accepts_an_empty_as_pathgit diff --checkFixes #1135.