feat: log OpenDAL retries as a single line - #562
Merged
Conversation
Replace the default OpenDAL retry interceptor, which Debug-dumps the full error context tree, with a one-line warning matching the REST backend.
aawsome
requested changes
Sep 4, 2026
aawsome
left a comment
aawsome
left a comment
Member
There was a problem hiding this comment.
Hi @BradKollmyer ! Thanks for the PR! LGTM, but please remove the changelog edit - we document changes in the git history and the changelog gets generated.
aawsome
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Debugcontext treeError {err} at {duration:?}, retrying ...Why
Temporary backend errors such as B2
connection closed before message completedare already retried. The default interceptor formats the error with{:?}, which prints a multi-line Context/Source dump and overwrites progress output. OpenDAL'sDisplayform is already a single line.Validation
cargo test -p rustic_backend --lib opendalcargo clippy -p rustic_backend --lib -- -D warningsA companion rustic CLI PR captures console logs while the TUI owns the terminal so remaining log output cannot overwrite the progress popup.