Skip to content

chore(cargo): disable debug info in generated profiles#242

Merged
dpc merged 1 commit into
rustshop:masterfrom
dpc:dpc/jj-vxnnmprntpzn
Jul 24, 2026
Merged

chore(cargo): disable debug info in generated profiles#242
dpc merged 1 commit into
rustshop:masterfrom
dpc:dpc/jj-vxnnmprntpzn

Conversation

@dpc

@dpc dpc commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Posted by Tau

Summary

Default development and CI Cargo profiles to debug = false in Flakebox, generated projects, and the Cargo profile lint fixer. Keep explicit dependency package overrides so projects can later enable workspace-only line tables without enabling dependency debug information.

Details

  • generate explicit development and CI dependency profile overrides
  • preserve existing inline TOML settings while normalizing tables
  • cover generated values, serialization, comments, and inline-table preservation
  • update the best-practices documentation

Testing

Run selfci check.

### Summary

Default development and CI Cargo profiles to `debug = false` in Flakebox itself, the default project template, and the Cargo profile lint fixer. Retain explicit dependency package overrides so projects can later enable workspace-only line tables without paying for dependency debug information.

### Details

Generate `[profile.dev.package."*"]` and `[profile.ci.package."*"]` overrides with comments explaining the workspace `line-tables-only` option. Normalize valid inline TOML tables before updating them so the fixer preserves existing settings, and add focused coverage for generated values, serialization, comments, and inline-table preservation. Update the best-practices example; release-profile behavior remains unchanged.

### Verification

`cargo test -p flakebox`, Cargo metadata validation, treefmt, and `selfci check` pass.

### Reviews

Focused correctness and maintainability review found malformed inline serialization/comment placement, then uncovered preservation bugs for nested and root inline tables. The implementation now emits explicit override sections, places comments before `debug`, normalizes every table level, and preserves existing inline settings. Final re-review passed with no issues.

### Summary of the original prompt

Apply the Cargo debug-profile defaults documented by dpc-public-skills change `myutwysq`, keeping the scope to Flakebox generated/default Cargo configuration and directly related tests/docs.
@dpc
dpc force-pushed the dpc/jj-vxnnmprntpzn branch from 45dc994 to 2b17ebe Compare July 24, 2026 17:14
@dpc
dpc marked this pull request as ready for review July 24, 2026 17:17
@dpc
dpc merged commit fbcd95c into rustshop:master Jul 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant