Dependency updates and bincode-next migration#294
Merged
Conversation
Migrate the WebSocket wire-format codec from bincode 1.3.3 to bincode-next 3.1.1, using its serde-compat encode/decode functions so the existing message-type definitions in pudlib need no changes. Centralize the codec behind new pudlib::serialize/deserialize wrappers (pudlib/src/utils.rs) instead of having puds, pudw, and pudcli each depend on the bincode crate directly, and update all 11 call sites accordingly. Add a round-trip unit test covering the new codec. Note: this changes the wire format - puds, pudw, and pudcli must be rebuilt and redeployed together. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #294 +/- ##
==========================================
+ Coverage 44.74% 45.21% +0.47%
==========================================
Files 42 42
Lines 3158 3187 +29
==========================================
+ Hits 1413 1441 +28
- Misses 1745 1746 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
depsup), including pinningtimedue to a breaking change upstreambincode1.3.3 tobincode-next3.1.1, using its serde-compat encode/decode functions so existing message-type definitions inpudlibneed no changespudlib::serialize/deserializewrappers instead of havingpuds,pudw, andpudclieach depend onbincodedirectly; add a round-trip unit testNote: the bincode migration changes the wire format —
puds,pudw, andpudclimust be rebuilt and redeployed together.🤖 Generated with Claude Code