fix: harden MCP, native HNSW gates, and ruvector 0.2.37 - #724
Merged
Conversation
ruvnet
marked this pull request as ready for review
July 27, 2026 16:00
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruvector mcp startand keeps MCP stdout JSON-RPC-only (closes mcp start: console.log in ONNX loader corrupts stdout JSON-RPC → 'Failed to connect' in Claude Code #710, closes mcp start: server registers handlers but never listens — mcp-server.js gates bootstrap on require.main === module, which cli.js can never satisfy #715)taradvisory, updates Google Redis/protobuf resolution, and preparesruvector@0.2.37Root causes
The CLI loaded the MCP server as a module whose guarded
main()was never invoked. ONNX diagnostics also wrote to stdout and could corrupt the stdio transport. Separately, the JavaScript wrapper forwarded an omittedhnswConfigasundefined; N-API mapped that toNone, selecting FlatIndex instead of the Rust core HNSW default. CI omitted optional dependencies, so its performance and recall jobs exercised the fallback rather than the native engine.Validation
cargo check --workspace --all-targets --locked— passes across the workspacecargo fmt --all -- --check— passescargo auditandcargo deny check advisories— passnpm test— passes 73 CLI checks plus database, MCP handshake/stdout, signals, access policy, and startup guardsnpm run build && npm run verify-dist— passesnpm pack --dry-run --json --ignore-scripts— valid 0.2.37 tarball, 153 filesSupply-chain note
GitHub does not currently expose this repository dependency graph to dependency-review-action. That single service-dependent step is soft-failed while #689 tracks the prerequisite; Cargo audit, Cargo deny, npm critical audit, and lockfile integrity remain hard gates.