-
Notifications
You must be signed in to change notification settings - Fork 1
Implement and test new thermal physics model #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement and test new thermal physics model #8
Conversation
Co-authored-by: langleyreview <langleyreview@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: langleyreview <langleyreview@gmail.com>
Co-authored-by: langleyreview <langleyreview@gmail.com>
Co-authored-by: langleyreview <langleyreview@gmail.com>
|
@cursor fix the ci tests |
|
I've fixed the CI test failure. The issue was that the SWIG wrapper compilation was failing because:
Changes made:
The commit has been pushed and CI will re-run automatically. Learn more about Cursor Agents |
- Add override keywords to IsotropicHeat and IsotropicLinearThermoelasticity to properly override pure virtual methods from base classes - Update SWIG interface files to include all overridden virtual methods to prevent compilation errors when generating Python bindings
|
@cursor fix ci docker build error |
|
I've fixed the CI docker build error. The issues were:
Changes made:
The kernel methods are internal implementation details used only by the C++ integrator and don't need to be exposed to Python. The commit has been pushed and CI will re-run automatically. Learn more about Cursor Agents |
- Remove constructors from abstract base classes RheologyHeat and RheologyThermoelasticity to prevent SWIG from generating code that tries to instantiate abstract classes - Remove kernel methods that return function pointers (PetscPointFn*, PetscPointJac) from concrete classes - these are internal implementation details that cannot be properly wrapped by SWIG - Keep only the methods that can be properly exposed to Python
Co-authored-by: langleyreview <langleyreview@gmail.com>
Implement a new thermal physics model to support heat conduction, thermoelasticity, porothermoelasticity, and fluid-thermal coupled simulations.
Note
Introduce heat conduction and thermoelasticity physics (kernels, materials, Python bindings), new solution field types, and comprehensive full‑scale and MMS tests.
HeatEquation(time term, source, Jacobian) andIsotropicHeat(heat flux f1/g1, Jf3,heatFluxprojection).Thermoelasticity(coupled inertia and thermoelastic heating, Jacobians) andIsotropicLinearThermoelasticity(stress f1 in 2D/3D, Jf3uu/Jf2uT/Jf3TT,cauchyStress,heatFlux).Heat/IsotropicHeatandThermoelasticity/IsotropicLinearThermoelasticitywith integrator setup, solver defaults, and derived/auxiliary factories (AuxiliaryFactoryHeat,DerivedFactoryHeat,AuxiliaryFactoryThermoelasticity).density,specific_heat,thermal_conductivity,reference_temperature,thermal_expansion_coefficient,shear_modulus,bulk_modulus; derivedheat_fluxoutput.SolnTemp,SolnPresTemp,SolnDispTemp,SolnDispVelTemp,SolnDispPresTemp.Written by Cursor Bugbot for commit 3d2f6e2. This will update automatically on new commits. Configure here.