feat: SSE frame parser (core slice of #46) - #49
Merged
Conversation
First slice of #46: a streaming, spec-compliant Server-Sent Events frame parser under src/core/sse/, fully unit-testable without VS Code or network. - SseParser: stateful, chunked; handles CR / LF / CRLF (incl. CRLF split across chunks), leading BOM, ':' comments, unknown fields, multi-'data:' join, NUL-in-'id:' rejection, digits-only 'retry:'. - SseEventSchema: zod validation for dispatched events; sticky lastEventId / retry across events per spec. - parseSse() one-shot convenience wrapper. - 22 vitest cases covering the WHATWG examples plus edge cases. Follow-up work (response viewer streaming mode, '@sse-until' directive, reconnect + Last-Event-ID wiring, transcript persistence) stays tracked under #46.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes part of #46 — first shippable slice.
What
Pure Server-Sent Events frame parser at
src/core/sse/, WHATWG-spec-compliant, no VS Code /undicideps.Highlights
SseParser— stateful streaming API (push/end/drain); handles chunk-split CRLF, leading BOM, comments, unknown fields, multi-data:join, stickylastEventId/retry, NUL-in-id:rejection, digits-onlyretry:.SseEventSchema(zod) validating every dispatched event.parseSse()one-shot helper.Not in this PR (still under #46)
# @sse-until <expr>directiveundiciwire-up + reconnect /Last-Event-IDheader.sse.jsonltranscript persistenceKept small and pure to land the foundation first; follow-ups will layer on it.
Checks
npm run lint✅npm run typecheck✅npm run test:unit✅ (431 passed, 22 new)