Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce jittery/over-frequent “scroll to bottom” behavior in the mobile chat UI by debouncing automatic bottom-follow during streaming updates, and it also refactors desktop-side mobile branch-op handling to keep mobilePendingWorktrees in sync in both branch operations.
Changes:
- Add a debounced auto-scroll mechanism for mobile chat bottom-follow during streaming/layout-driven updates.
- Cancel any pending debounced auto-scroll when the user sends a message, pins to top, or taps the “scroll to bottom” button.
- Refactor pending-worktree bookkeeping into a shared helper and apply it to both “switch existing” and “create new” mobile branch operations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| RxCodeMobile/Views/MobileChatView.swift | Introduces debounced auto-scroll task/state to coalesce repeated scroll-to-bottom triggers. |
| RxCode/App/AppState+MobileSync.swift | Refactors and unifies pending worktree update/removal after mobile branch operations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1096
to
+1106
| autoBottomScrollTask = Task { @MainActor in | ||
| if delay > 0 { | ||
| try? await Task.sleep(nanoseconds: UInt64(delay * 1_000_000_000)) | ||
| } | ||
| guard !Task.isCancelled else { return } | ||
| autoBottomScrollTask = nil | ||
| guard didEstablishInitialScroll, | ||
| autoScrollEnabled, | ||
| !isUserDragging, | ||
| !isPinningLatestTurnToTop | ||
| else { return } |
| /// user actions and initial thread positioning still scroll immediately. | ||
| private func scrollToBottomDebounced(proxy: ScrollViewProxy, reason: String) { | ||
| guard autoBottomScrollTask == nil else { return } | ||
| let elapsed = Date().timeIntervalSince(lastAutoBottomScrollDate) |
Contributor
Author
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.