Android trends: neutralize card surfaces (EXP-004 parity) - #1080
Merged
Conversation
Drop the green (chargeColor) surface glow from the HRV and Resting-HR small multiples, the Week-in-Review card, and the Charge history strip, matching the iOS Trends cleanup (#1068). The semantic colors stay INSIDE the data graphics: the HRV line stays purple, the RHR line stays rose, and the Week-in-Review Charge pip keeps its green fill. Card contents, order, chart data, and interactions are unchanged. The Charge hero already renders neutral (its liquid frosted wrapper ignores the tint); its dead tint argument is removed for clarity. Display-only; no data/logic change. Android-only (iOS via #1068). compileFullDebugKotlin + i18n audit green; not device-verified (Compose does not render on Linux).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Neutralizes the Trends card surfaces to match the iOS cleanup (#1068's EXP-004): drops the green (
chargeColor) surface glow from the HRV and Resting-HR small multiples, the Week-in-Review card, and the Charge history strip.Semantic colors stay inside the data graphics (the key constraint): the HRV line stays purple, the RHR line stays rose, and the Week-in-Review Charge pip keeps its green fill. Card contents, order, chart data, and interactions are unchanged.
The Charge hero already renders neutral on Android — its liquid frosted-black wrapper ignores the
tintunderliquidHero=true— so it needed no visual change; its deadtintargument is removed for clarity.Scoped from the #1068 parity gap analysis (the one clearly-worthwhile cosmetic item). Note: iOS's EXP-004 also removed a redundant "WEEK IN REVIEW" subtitle, but that's entangled with Android's deliberate pip-language weekly summary (EXP-009/012, which the gap analysis flagged as a regression to port) — so this PR is the tint neutralization only.
Cross-platform
Android-only (iOS via #1068). No analytics, decoder, stored-data, or BLE change — pure surface-tint removal.
Testing
:app:compileFullDebugKotlin— BUILD SUCCESSFUL.Tools/i18n_audit.py --ci— exit 0 (no string changes).