sleep: widen hypnogram axis edge guard for 12h labels - #1134
Merged
Conversation
Re-review of #1133: the edge drop-guard was tuned for a ~40dp 24h edge label ('10:25'), but a 12h edge is wider ('10:25 AM' ~55dp). An interior mark near the old boundary (frac ~0.83) could touch the clamped onset/wake label on a 12h device — the axis Layout clamps edges into view but doesn't drop-on-collision. 0.18/0.82 gives the wider edge clearance and drops nothing on real nights (phone 03:00/06:00 at .32/.60; tablet 02/04/06/08 at .23-.78). Also drops a stale '~90dp' comment left from the density change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-review follow-up to #1133.
The interior round-hour drop-guard was
0.15/0.85, sized for a ~40dp 24h edge label (10:25). A 12h edge is wider (10:25 AM~55dp), so a mark landing near the boundary (frac ~0.83) could touch the clamped onset/wake label — the axisLayoutclamps edges on-screen but doesn't drop-on-collision. Widened to0.18/0.82.Costs nothing on real nights (verified): phone keeps
03:00/06:00(.32/.60), tablet keeps02/04/06/08(.23–.78). Also removed a stale~90dpcomment from the earlier 60dp density change.Android-only, render-only.
compileFullDebugKotlin✓,HypnogramAxisTicksTest✓ (guard change keeps all shape/format assertions green).