Skip to content

Clarify phone heart-rate broadcast copy#356

Closed
kavemang wants to merge 1 commit into
ryanbr:mainfrom
kavemang:agent/clarify-phone-hr-broadcast
Closed

Clarify phone heart-rate broadcast copy#356
kavemang wants to merge 1 commit into
ryanbr:mainfrom
kavemang:agent/clarify-phone-hr-broadcast

Conversation

@kavemang

Copy link
Copy Markdown

What

Clarifies the Android Data Sources copy for the phone heart-rate broadcast feature.

Why

The card could read like a required strap setting even for users whose WHOOP/watch already broadcasts heart rate directly to another device. The updated copy explains that this is only for making the phone rebroadcast live strap HR as a standard Bluetooth HR sensor, and that users can leave it off when their wearable already handles HR broadcasting natively.

It also fixes the enabled warning to say the phone is advertising continuously, not the strap.

Closes #159.

Validation

  • ./gradlew :app:compileFullDebugKotlin

@kavemang
kavemang marked this pull request as ready for review July 13, 2026 01:15
@ryanbr

ryanbr commented Jul 13, 2026

Copy link
Copy Markdown
Owner

The Android copy is accurate and this closes #159 cleanly — I confirmed the third change ("This phone is advertising" instead of "Your strap is advertising") is a real correctness fix, since it's the phone that acts as the BLE HR peripheral. Safe to merge on its own. One thing missing though: it's one-sided.

Missing: the iOS twin card

Strand/Screens/DataSourcesView.swift:784 is the exact same "Broadcast HR from this phone" card and didn't get the same clarifications:

One heads-up for the iOS side

iOS copy is localized (String(localized:).xcstrings), so mirroring these two lines touches the string catalog, and the German translations (#326) will fall back to English until updated. Android's strings are inline literals, so this PR had no such cost — which is why the two platforms need slightly different handling.

None of this blocks the Android change. Just flagging that the #159 fix is only half-applied until the iOS DataSourcesView card gets the same subtitle + footnote copy — worth either folding in here or tracking as a quick follow-up.

@kavemang

Copy link
Copy Markdown
Author

Superseded by #508, which carries the identical change from the corrected issue-oriented branch.

@kavemang kavemang closed this Jul 16, 2026
@kavemang
kavemang deleted the agent/clarify-phone-hr-broadcast branch July 16, 2026 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Data sources - option broadcasting heart rate not needed?

2 participants