Settings: add missing row dividers in the Appearance card (#79)#83
Merged
Conversation
On iOS the Appearance card's segmented rows (Theme / Chart colours / App icon) sat flush against each other — its VStack(spacing: 0) had no rowDivider between the rows, unlike every other card (Profile etc.). Add the standard rowDivider between them; the App-icon divider sits inside #if os(iOS) so macOS keeps a single divider before the toggles (no double line). Android parity: the rows there were already 16dp-spaced (SettingsSection's content Column), but lacked the hairline every other section draws between FormRows — add RowDivider() between Theme and Chart colours to match iOS and the rest of Settings. Layout only. Android compiles locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79 — in the Appearance card on iOS, the option rows touch each other, unlike the card above it.
Cause
SettingsView.appearanceCardlays its rows inVStack(spacing: 0)but — unlikeprofileCardand every other card — has norowDividerbetween Theme → Chart colours → App icon. So they sit flush. (rowDivideris the standard 1px hairline + 4pt padding used throughout Settings.)Fix
rowDividerbetween Theme↔Chart colours and Chart colours↔App icon. The App-icon divider is inside#if os(iOS), so macOS (no App-icon row) keeps a single divider before the toggle section — no double line.SettingsSection's contentColumn(spacedBy(16.dp))), so they weren't touching — but they lacked the hairline every other Android section draws between FormRows. AddedRowDivider()between Theme and Chart colours so it matches iOS and the rest of Settings.Layout only, no behavior change.
Testing
Android compiles locally (
compileFullDebugKotlin, exit 0). iOS is a trivial view insertion (CI-gated on WSL). Verified by inspection against theprofileCard/other-section pattern.Files:
Strand/Screens/SettingsView.swift,android/.../SettingsScreen.kt.