Point issue references at this repo, not a repo that no longer exists - #939
Merged
Conversation
Merged
9 tasks
Two comment inaccuracies, no behaviour. The sleep files carried #600 and #690 from the project's pre-fork repo. Neither resolves here, and worse, both collide: this repo's #600 is an iOS Target Strain notification and its #690 is the body-location probe, which BodyLocationProbe cites correctly. So the same number meant two things depending on the file. Rewritten to references that resolve in THIS repo: - the V2 recipe keeps its credit as @sunny-noop, matching how the same contributor is credited in HealthExportPlan and SpotHrvReading, and drops the dead repo path - the V2-flag sites now cite 7.0.0, the release that introduced SleepStagerV2 here (CHANGELOG.md:240; the file arrived in commit 4da3cfb), plus #277/#351 for the default-ON claim, which those files already cite a line above - HrBroadcaster's credit keeps ryanbr, loses the dead path github.com/NoopApp/noop 404s and this repo is a fork whose parent no longer resolves, so every one of those links was dead. Nothing live pointed there: UpdateChecker and UpdateCheck both read api.github.com/repos/ryanbr/noop, and both About links go to github.com/ryanbr/noop. The two AppChangelog entries that mention NoopApp are left alone deliberately — they are the shipped release notes for the version that made that change, and rewriting them would falsify the record rather than correct it. Also: ReportReviewGate described the Oura Tier-B sidecars as capped at 20 MB. Both dumps enforce 25 MB (OuraActivityDump.maxBytes / OuraMotionDump.maxBytes).
ryanbr
force-pushed
the
fix/qualify-upstream-refs-and-cap
branch
from
July 29, 2026 00:35
b758a9a to
d374b08
Compare
ryanbr
changed the title
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments only — no schema, no behaviour, no stored value.
The problem
The sleep files carried
#600and#690from the project's pre-fork repo.github.com/NoopApp/noop404s and this repo is a fork whose parent no longer resolves, so those links were dead — and worse, they
collide with real numbers here:
#600#690BodyLocationProbeSo
#690meant two different things depending on which file you were reading.Now pointed at this repo
@sunny-noopand loses the dead path — matching how the samecontributor is already credited in
HealthExportPlan.ktandSpotHrvReading.kt.SleepStagerV2here(
CHANGELOG.md:240; the file arrives in commit4da3cfb4), plus feat(sleep): promote Sleep V2 to the default staging engine + tune deep boundary #277/Sleep: V2 default for every strap, with a V1 revert toggle (reworks #347) #351 for the default-ONclaim — which those same files already cite one line above.
HrBroadcaster's credit keeps ryanbr, loses the dead path.BodyLocationProbeis untouched. Its#690was always right.Nothing live pointed at the old repo — checked, because a dead update endpoint would have mattered
more than any comment.
UpdateChecker.swift:21andUpdateCheck.kt:18both readapi.github.com/repos/ryanbr/noop/releases/latest, and both About links go togithub.com/ryanbr/noop.The two
AppChangelogentries mentioning NoopApp are deliberately left alone. They are the shippedrelease notes for the version that made that change; rewriting them would falsify the record rather than
correct it.
Also: the Oura sidecar cap
ReportReviewGatedescribed the Tier-B sidecars as "each up to the 20 MB cap". Both dumps enforcemaxBytes = 25 * 1024 * 1024. Relevant to #937, which adds a third sidecar and should not copy a wrongnumber.
Verification
Comments only — verified mechanically, zero non-comment changed lines across all ten files.
Tools/doc_comment_lint.pyclean.(This also supersedes my review note on #925, which suggested renumbering these to
#347 → #351 → #277.That would have destroyed a contributor's provenance — the numbers were pre-fork, not stale.)