Forecast NWS: explicit Home/Custom location selector — v0.16.2#29
Merged
Merged
Conversation
Replace the optional "leave latitude/longitude blank for home" NWS fields with an explicit Location select: `home` (default — uses the Home Assistant location) or `custom` (reveals latitude/longitude inputs). The card only uses custom coordinates when location is `custom`, otherwise it always falls back to the Home Assistant location. Updates README + docs/cards.md (location row + a custom-coordinates example) and the NWS smoke case. VERSION 0.16.1 -> 0.16.2. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014cpNPVU8j1iiU9CnXgr5JY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
For the forecast card's NWS source, replaces the previous "optional latitude/longitude, leave blank for home" fields with an explicit Location selector:
location: home, default) — uses your HA coordinates.location: custom) — reveals latitude/longitude inputs.The card only applies custom coordinates when
location: custom; otherwise it always falls back to the Home Assistant location.Why
Requested — the coordinate inputs weren't discoverable (they read as optional overrides), so the ask was to keep the home-location option but add a clear custom option. Now it's a visible two-way choice that reveals the inputs only when needed.
Testing
bash build.sh+node test/smoke.jsgreen (NWS smoke case updated tolocation: custom). In-browser visual confirmation isn't available in this sandbox (no outbound network for the headless Chromium).VERSION 0.16.1 → 0.16.2.
🤖 Generated with Claude Code
Generated by Claude Code