Skip to content

(via ryandens): Remove manual Windows path quoting in JavaForkOptionsConfigurer.asArgume#373

Merged
ryandens merged 7 commits into
ryandens/windows-buildfrom
macroscope/ryandens/windows-build
Jul 6, 2026
Merged

(via ryandens): Remove manual Windows path quoting in JavaForkOptionsConfigurer.asArgume#373
ryandens merged 7 commits into
ryandens/windows-buildfrom
macroscope/ryandens/windows-build

Conversation

@macroscopeapp

@macroscopeapp macroscopeapp Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR fixes Windows build issues by addressing path quoting and script execution problems.

Changes

Remove manual Windows path quoting in JavaForkOptionsConfigurer

  • Removed redundant manual path quoting logic in asArguments() method
  • JavaForkOptions already handles argument quoting properly, making the manual implementation unnecessary
  • Cleaned up unused OperatingSystem import

Fix Windows CI build script execution

  • Updated .github/workflows/gradle.yml to conditionally use the correct Gradle wrapper script based on platform
  • Uses gradlew.bat on Windows and ./gradlew on Unix systems
  • Fixes PowerShell execution failure that occurred when trying to run the Unix-style command on Windows

Note

Macroscope: Fix It For Me

  • This PR originated from this comment in ✅ add support for Windows #48.
  • Since auto-merge is on, Macroscope will merge this PR after waiting for checks to pass.
  • If you'd rather not wait, you can always merge this yourself but no further action from you is currently needed.
  • You can also @mention Macroscope in this PR to request further changes.

Activity

Currently: Not merged: unknown mergeable state

Previously
  • Waiting on checks
  • Pushed c17b413
  • Merged by ryandens
  • Action failed: Validate
  • Waiting on checks
  • Pushed e2a04de
  • Action failed: Validate
  • Waiting on checks
  • Pushed 16f8c45
  • Action failed: Validate
  • Waiting on checks
  • Pushed 25b3842
  • Action failed: Validate
  • Waiting on checks
  • Pushed e3f3caf
  • Action failed: Validate
  • Waiting on checks
  • Pushed 48410fa
  • Action failed: Validate
  • Waiting on checks
  • Pushed 31f55b7

Note

Fix generated start scripts to use platform-appropriate app home variable on Windows

  • The Platform enum gains an appHomeVar property ($APP_HOME on Unix, %APP_HOME% on Windows), used by JavaagentAwareStartScriptGenerator.FakeTransformer when building -javaagent arguments.
  • Previously, generated start scripts always used $APP_HOME, producing broken paths on Windows; they now use %APP_HOME% with backslash separators on Windows.
  • CI workflow and functional tests are updated to run gradlew.bat on Windows and assert OS-appropriate script content.

Macroscope summarized e2a04de.

@ryandens ryandens merged commit 595b7bf into ryandens/windows-build Jul 6, 2026
3 of 4 checks passed
@ryandens ryandens deleted the macroscope/ryandens/windows-build branch July 6, 2026 04:37
@macroscopeapp macroscopeapp Bot restored the macroscope/ryandens/windows-build branch July 6, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant