Skip to content

Preserve DNS resolver order in diagnostics and HTTP/3#687

Merged
ryanfowler merged 1 commit into
mainfrom
fix-dns-diagnostics-connection-order
Jun 1, 2026
Merged

Preserve DNS resolver order in diagnostics and HTTP/3#687
ryanfowler merged 1 commit into
mainfrom
fix-dns-diagnostics-connection-order

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • Keep transport socket addresses in resolver order so diagnostics no longer change connection preference.
  • Switch DNS timing output to stable deduping in original resolver order instead of sorting by family.
  • Reuse the first resolved address family for HTTP/3 preference/fallback, matching TCP connect_first.
  • Remove the unused sorted IP helper and update the repo guidance to match the new invariant.

Testing

  • cargo fmt
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • cargo test --all-features
  • cargo test --all-features --test cli --test formatting --test grpc --test http --test network --test terminal --test update --test websocket -- --test-threads=1

@ryanfowler ryanfowler merged commit a3e7e65 into main Jun 1, 2026
4 checks passed
@ryanfowler ryanfowler deleted the fix-dns-diagnostics-connection-order branch June 1, 2026 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant