Skip to content

Protect concurrent session cookie saves#694

Merged
ryanfowler merged 1 commit into
mainfrom
fix-concurrent-session-cookie-loss
Jun 2, 2026
Merged

Protect concurrent session cookie saves#694
ryanfowler merged 1 commit into
mainfrom
fix-concurrent-session-cookie-loss

Conversation

@ryanfowler

Copy link
Copy Markdown
Owner

Summary

  • Add a per-session advisory lock around session file saves
  • Reload the latest session JSON before writing and merge local cookie creates, updates, and deletions
  • Cover the interleaved-save case with regression tests so distinct cookies survive concurrent --session runs

Testing

  • cargo fmt
  • cargo clippy --locked --all-targets --all-features -- -D warnings
  • cargo test --all-features
  • cargo test --all-features --test cli --test formatting --test grpc --test http --test network --test terminal --test update --test websocket -- --test-threads=1

@ryanfowler ryanfowler enabled auto-merge June 2, 2026 13:19
@ryanfowler ryanfowler merged commit 96d78b7 into main Jun 2, 2026
4 checks passed
@ryanfowler ryanfowler deleted the fix-concurrent-session-cookie-loss branch June 2, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant